style: enable and fix many flake8 issues #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xywei This should be ready for a look. It touches quite a few places, but it should be just style fixes + the flake8 CI passes now! ❤️ |
|
Great, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #5, so needs to go after that. The commits are fairly self-contained, but essentially
pyupgradefixes, mainly to remove thefrom __future__ import print_functionstuffflake8-quotesissuesflake8-isortissuesThis should get the code into a reasonable state linting-wise. It would be nice to also enable
pylint, but for another PR 😁